fix: Stats and StatsGl don't remove previous class names on rerender (#…

…1994) * fix(StatsGl): remove class names on useEffect cleanup * fix(Stats): remove class names on useEffect cleanup
pmndrs · Jun 15, 2024 · 18c24eb · 18c24eb
1 parent 1bb5b95
commit 18c24eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/core/Stats.tsx b/src/core/Stats.tsx
@@ -17,10 +17,12 @@ export function Stats({ showPanel = 0, className, parent }: Props): null {
       const node = (parent && parent.current) || document.body
       stats.showPanel(showPanel)
       node?.appendChild(stats.dom)
-      if (className) stats.dom.classList.add(...className.split(' ').filter((cls) => cls))
+      const classNames = (className ?? '').split(' ').filter((cls) => cls)
+      if (classNames.length) stats.dom.classList.add(...classNames)
       const begin = addEffect(() => stats.begin())
       const end = addAfterEffect(() => stats.end())
       return () => {
+        if (classNames.length) stats.dom.classList.remove(...classNames)
         node?.removeChild(stats.dom)
         begin()
         end()

diff --git a/src/core/StatsGl.tsx b/src/core/StatsGl.tsx
@@ -23,9 +23,11 @@ export function StatsGl({ className, parent, ...props }: Props) {
     if (stats) {
       const node = (parent && parent.current) || document.body
       node?.appendChild(stats.dom)
-      if (className) stats.container.classList.add(...className.split(' ').filter((cls) => cls))
+      const classNames = (className ?? '').split(' ').filter((cls) => cls)
+      if (classNames.length) stats.dom.classList.add(...classNames)
       const end = addAfterEffect(() => stats.update())
       return () => {
+        if (classNames.length) stats.dom.classList.remove(...classNames)
         node?.removeChild(stats.dom)
         end()
       }