fix: refactor the ScrollProps type for maintainability and readability (

#1888)
pmndrs · Apr 2, 2024 · 7607bb0 · 7607bb0
1 parent 5410889
commit 7607bb0
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/src/web/ScrollControls.tsx b/src/web/ScrollControls.tsx
@@ -254,14 +254,19 @@ const ScrollHtml: ForwardRefComponent<{ children?: React.ReactNode; style?: Reac
     }
   )
 
-type ScrollProps =
-  | { children?: React.ReactNode } & (
-      | {
-          html?: false
-          style?: never
-        }
-      | { html: true; style?: React.CSSProperties }
-    )
+interface ScrollPropsWithFalseHtml {
+  children?: React.ReactNode
+  html?: false
+  style?: never
+}
+
+interface ScrollPropsWithTrueHtml {
+  children?: React.ReactNode
+  html: true
+  style?: React.CSSProperties
+}
+
+type ScrollProps = ScrollPropsWithFalseHtml | ScrollPropsWithTrueHtml
 
 export const Scroll: ForwardRefComponent<ScrollProps, THREE.Group & HTMLDivElement> = /* @__PURE__ */ React.forwardRef(
   ({ html, ...props }: ScrollProps, ref) => {