Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper now useHelper #1992

Merged
merged 1 commit into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/Caustics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as THREE from 'three'
import * as React from 'react'
import { extend, ReactThreeFiber, useFrame, useThree } from '@react-three/fiber'
import { useFBO } from './useFBO'
import { useHelper } from './useHelper'
import { useHelper } from './Helper'
import { shaderMaterial } from './shaderMaterial'
import { Edges } from './Edges'
import { FullScreenQuad } from 'three-stdlib'
Expand Down
68 changes: 41 additions & 27 deletions src/core/Helper.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,44 @@
import { useFrame, useThree } from '@react-three/fiber'
import * as React from 'react'
import { Object3D } from 'three'
import { useThree, useFrame } from '@react-three/fiber'
import { Falsey } from 'utility-types'

type HelperType = Object3D & { update: () => void; dispose: () => void }
type HelperConstructor = new (...args: any[]) => HelperType
type HelperConstructor = new (...args: any[]) => any
type HelperArgs<T> = T extends [infer _, ...infer R] ? R : never

export function useHelper<T extends HelperConstructor>(
object3D: React.MutableRefObject<Object3D> | Falsey,
helperConstructor: T,
...args: HelperArgs<ConstructorParameters<T>>
) {
const helper = React.useRef<HelperType>()
const scene = useThree((state) => state.scene)
React.useLayoutEffect(() => {
let currentHelper: HelperType = undefined!

if (object3D && object3D?.current && helperConstructor) {
helper.current = currentHelper = new (helperConstructor as any)(object3D.current, ...args)
}

if (currentHelper) {
// Prevent the helpers from blocking rays
currentHelper.traverse((child) => (child.raycast = () => null))
scene.add(currentHelper)
return () => {
helper.current = undefined
scene.remove(currentHelper)
currentHelper.dispose?.()
}
}
}, [scene, helperConstructor, object3D, ...args])

useFrame(() => void helper.current?.update?.())
return helper
}

//

export type HelperProps<T extends HelperConstructor> = {
type: T
args?: HelperArgs<ConstructorParameters<T>>
Expand All @@ -15,33 +48,14 @@ export const Helper = <T extends HelperConstructor>({
type: helperConstructor,
args = [] as never,
}: HelperProps<T>) => {
const objectRef = React.useRef<Object3D>(null!)
const helperRef = React.useRef<HelperType>()

const scene = useThree((state) => state.scene)
const thisRef = React.useRef<Object3D>(null!)
const parentRef = React.useRef<Object3D>(null!)

React.useLayoutEffect(() => {
const parent = objectRef.current?.parent

if (!helperConstructor || !parent) return

const helper = new helperConstructor(parent, ...args)

helperRef.current = helper

// Prevent the helpers from blocking rays
helper.traverse((child) => (child.raycast = () => null))

scene.add(helper)

return () => {
helperRef.current = undefined
scene.remove(helper)
helper.dispose?.()
}
}, [scene, helperConstructor, ...args])
parentRef.current = thisRef.current.parent!
})

useFrame(() => void helperRef.current?.update?.())
useHelper(parentRef, helperConstructor, ...args)

return <object3D ref={objectRef} />
return <object3D ref={thisRef} />
}
1 change: 0 additions & 1 deletion src/core/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export * from './useDepthBuffer'
export * from './useAspect'
export * from './useCamera'
export * from './useDetectGPU'
export * from './useHelper'
export * from './useBVH'
export * from './useContextBridge'
export * from './useAnimations'
Expand Down
38 changes: 0 additions & 38 deletions src/core/useHelper.tsx

This file was deleted.

Loading