Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): resolve infinite loop with loadable of derived async atom in some cases #1118

Merged
merged 2 commits into from
Apr 28, 2022
Merged

fix(core): resolve infinite loop with loadable of derived async atom in some cases #1118

merged 2 commits into from
Apr 28, 2022

Conversation

hirokibeta
Copy link
Contributor

fix #1114

@vercel
Copy link

vercel bot commented Apr 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Apr 24, 2022 at 5:39AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77deff1:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration
cool-clarke-rnnntt Issue #1114
spring-fast-fdomd3 Issue #1114

@hirokibeta hirokibeta mentioned this pull request Apr 24, 2022
Closed
dai-shi
dai-shi approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your investigation!
So, this reverts #1089 which was a wrong fix, and we claim #1054 is an expected behavior.

@dai-shi dai-shi added this to the v1.6.5 milestone Apr 25, 2022
@dai-shi dai-shi mentioned this pull request Apr 26, 2022
Closed
@dai-shi dai-shi merged commit f08f345 into pmndrs:main Apr 28, 2022
@dai-shi dai-shi changed the title fix(utils): resolve infinite loop with loadable of derived async atom in some cases fix(core,utils): resolve infinite loop with loadable of derived async atom in some cases Apr 28, 2022
@dai-shi dai-shi changed the title fix(core,utils): resolve infinite loop with loadable of derived async atom in some cases fix(core): resolve infinite loop with loadable of derived async atom in some cases Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.5
Development

Successfully merging this pull request may close these issues.

Problems with derived atom which has a promise as its initial value
2 participants
@hirokibeta @dai-shi