Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve versionedWrite logic #1244

Merged
merged 55 commits into from
Jul 15, 2022
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jun 21, 2022

following up #1154, it should somehow be improved before fixing #1239 tests with versionedWrite.

  • investigating behavior
  • fix logic and pass tests

@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 3:36PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f6b3d2:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Jun 21, 2022

Size Change: +415 B (0%)

Total Size: 142 kB

Filename Size Change
dist/esm/index.js 4.91 kB +62 B (+1%)
dist/esm/urql.js 1.26 kB -26 B (-2%)
dist/esm/utils.js 4.83 kB +26 B (+1%)
dist/index.js 6.03 kB +62 B (+1%)
dist/system/index.development.js 5.13 kB +65 B (+1%)
dist/system/index.production.js 2.92 kB +17 B (+1%)
dist/system/urql.development.js 1.41 kB -32 B (-2%)
dist/system/urql.production.js 1.01 kB -17 B (-2%)
dist/system/utils.development.js 5.17 kB +27 B (+1%)
dist/system/utils.production.js 3.31 kB +28 B (+1%)
dist/umd/index.development.js 6.12 kB +63 B (+1%)
dist/umd/index.production.js 3.36 kB +31 B (+1%)
dist/umd/urql.development.js 1.77 kB -1 B (0%)
dist/umd/utils.development.js 9.65 kB +38 B (0%)
dist/umd/utils.production.js 6.22 kB +33 B (+1%)
dist/urql.js 1.62 kB +1 B (0%)
dist/utils.js 9.44 kB +38 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 945 B
dist/babel/plugin-react-refresh.js 1.16 kB
dist/babel/preset.js 1.41 kB
dist/devtools.js 3.85 kB
dist/esm/babel/plugin-debug-label.js 782 B
dist/esm/babel/plugin-react-refresh.js 996 B
dist/esm/babel/preset.js 1.23 kB
dist/esm/devtools.js 2.91 kB
dist/esm/immer.js 609 B
dist/esm/optics.js 661 B
dist/esm/query.js 1.03 kB
dist/esm/redux.js 251 B
dist/esm/valtio.js 526 B
dist/esm/xstate.js 766 B
dist/esm/zustand.js 284 B
dist/immer.js 726 B
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/system/babel/plugin-debug-label.development.js 889 B
dist/system/babel/plugin-debug-label.production.js 677 B
dist/system/babel/plugin-react-refresh.development.js 1.1 kB
dist/system/babel/plugin-react-refresh.production.js 863 B
dist/system/babel/preset.development.js 1.33 kB
dist/system/babel/preset.production.js 1.05 kB
dist/system/devtools.development.js 3.09 kB
dist/system/devtools.production.js 2.23 kB
dist/system/immer.development.js 733 B
dist/system/immer.production.js 469 B
dist/system/optics.development.js 765 B
dist/system/optics.production.js 455 B
dist/system/query.development.js 1.19 kB
dist/system/query.production.js 830 B
dist/system/redux.development.js 339 B
dist/system/redux.production.js 217 B
dist/system/valtio.development.js 639 B
dist/system/valtio.production.js 400 B
dist/system/xstate.development.js 868 B
dist/system/xstate.production.js 563 B
dist/system/zustand.development.js 372 B
dist/system/zustand.production.js 235 B
dist/umd/babel/plugin-debug-label.development.js 1.11 kB
dist/umd/babel/plugin-debug-label.production.js 839 B
dist/umd/babel/plugin-react-refresh.development.js 1.31 kB
dist/umd/babel/plugin-react-refresh.production.js 994 B
dist/umd/babel/preset.development.js 1.56 kB
dist/umd/babel/preset.production.js 1.19 kB
dist/umd/devtools.development.js 3.98 kB
dist/umd/devtools.production.js 2.69 kB
dist/umd/immer.development.js 871 B
dist/umd/immer.production.js 570 B
dist/umd/optics.development.js 1.08 kB
dist/umd/optics.production.js 671 B
dist/umd/query.development.js 1.5 kB
dist/umd/query.production.js 1.03 kB
dist/umd/redux.development.js 454 B
dist/umd/redux.production.js 322 B
dist/umd/urql.production.js 1.22 kB
dist/umd/valtio.development.js 722 B
dist/umd/valtio.production.js 500 B
dist/umd/xstate.development.js 1.36 kB
dist/umd/xstate.production.js 858 B
dist/umd/zustand.development.js 479 B
dist/umd/zustand.production.js 334 B
dist/valtio.js 586 B
dist/xstate.js 1.21 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi
Copy link
Member Author

dai-shi commented Jul 15, 2022

Finally, the tests are fairly stable more than ever.

@dai-shi dai-shi merged commit 2185393 into main Jul 15, 2022
@dai-shi dai-shi deleted the fix/core/versioned-write branch July 15, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant