-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): Handle ESM imports for @babel/template #1254
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit efe33b0:
|
Size Change: +309 B (0%) Total Size: 145 kB
ℹ️ View Unchanged
|
@dai-shi Not sure it works - Try this: Getting the same error. |
Not sure either, but the error message is different.
|
Should we merge and try? |
No, we don't need to merge for a try. Doesn't csb build work? One can install it locally. |
@dai-shi I tried out this PR version with https://github.com/alan-nf/jotai-vite-react-refresh and it works 💪🏼 Ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks okay.
This PR (hopefully) fixes ESM imports for
@babel/template
, when usingvite
.Fixes #1251.