Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor atomWithLazy #2485

Merged
merged 1 commit into from
Apr 6, 2024
Merged

refactor atomWithLazy #2485

merged 1 commit into from
Apr 6, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Apr 6, 2024

based on #2465

While woking on #2479 and enabling CJS tests, I noticed that with the current transpilation target, it expands {...} and makes the test to fail. So, let's refactor it to be compatible with transpiration.

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview Apr 6, 2024 2:37am

@dai-shi dai-shi added this to the v2.8.0 milestone Apr 6, 2024
@dai-shi dai-shi marked this pull request as ready for review April 6, 2024 02:37
Copy link

codesandbox-ci bot commented Apr 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Apr 6, 2024

Size Change: +106 B (0%)

Total Size: 92.6 kB

Filename Size Change
dist/system/vanilla/utils.development.js 4.94 kB +21 B (0%)
dist/system/vanilla/utils.production.js 3.03 kB +18 B (+1%)
dist/umd/vanilla/utils.development.js 5.86 kB +24 B (0%)
dist/umd/vanilla/utils.production.js 3.63 kB +19 B (+1%)
dist/vanilla/utils.js 5.72 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 927 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.4 kB
dist/experimental.js 5.13 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.42 kB
dist/system/babel/plugin-debug-label.development.js 1.1 kB
dist/system/babel/plugin-debug-label.production.js 771 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.58 kB
dist/system/babel/preset.production.js 1.14 kB
dist/system/experimental.development.js 3.97 kB
dist/system/experimental.production.js 1.89 kB
dist/system/index.development.js 253 B
dist/system/index.production.js 182 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 860 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 258 B
dist/system/utils.production.js 188 B
dist/system/vanilla.development.js 4.5 kB
dist/system/vanilla.production.js 2.17 kB
dist/umd/babel/plugin-debug-label.development.js 1.08 kB
dist/umd/babel/plugin-debug-label.production.js 855 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.54 kB
dist/umd/babel/preset.production.js 1.22 kB
dist/umd/experimental.development.js 5.23 kB
dist/umd/experimental.production.js 2.56 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.55 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla.development.js 5.47 kB
dist/umd/vanilla.production.js 2.79 kB
dist/utils.js 246 B
dist/vanilla.js 5.38 kB

compressed-size-action

Copy link

github-actions bot commented Apr 6, 2024

LiveCodes Preview in LiveCodes

Latest commit: 45abcfa
Last updated: Apr 6, 2024 2:37am (UTC)

Playground Link
React demo https://livecodes.io?x=id/C5WBVGSUM

See documentations for usage instructions.

@dai-shi dai-shi merged commit 93a6fb9 into main Apr 6, 2024
34 checks passed
@dai-shi dai-shi deleted the fix/atom-with-lazy branch April 6, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant