Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document layout flickering. #2514

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Fix document layout flickering. #2514

merged 4 commits into from
Apr 23, 2024

Conversation

ouweiya
Copy link
Contributor

@ouweiya ouweiya commented Apr 21, 2024

When the content in the main container is too short, the container will shrink, causing layout flickering.

Setting flex-grow on main can solve this problem, always keeping main to fill its parent container.

https://jotai.org/docs/utilities/reducer

chrome_MQyfcNABki.mp4

Adding the notranslate class to the code block component can prevent the code text from being translated by Google.

image

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:36am

Copy link

codesandbox-ci bot commented Apr 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Apr 21, 2024

LiveCodes Preview in LiveCodes

Latest commit: a489652
Last updated: Apr 23, 2024 4:35am (UTC)

Playground Link
React demo https://livecodes.io?x=id/7RMEM9FA4

See documentations for usage instructions.

Copy link
Collaborator

@sandren sandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ouweiya Thanks for this fix! 🙂

@sandren sandren merged commit 5a525d8 into pmndrs:main Apr 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants