fix(core): Unmount an atom that is no longer dependent within a derived atom

[nogaten]

Related Bug Reports or Discussions

Fix #2658

Summary

Add test for "Unmount an atom that is no longer dependent within a derived atom (#2658)" and fix.

Check List

• pnpm run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2024 8:59am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[github-actions]

Preview in LiveCodes

Latest commit: ddd9f42
Last updated: Jul 23, 2024 8:58am (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/6SNG5YSJJ

---

See documentations for usage instructions.

[dai-shi]

Thanks for the failing test!

I can take a closer look later, but if anyone is interested, feel free to take the challenge.

[nogaten]

Fix #2658.
When executing unmountAtom, it is confirmed that the dependent atom is not mounted, or even if it is mounted, it does not exist in dependent.

[dai-shi]

wow, it looks good to me! thanks for the fix.
there might be some other edge cases, this doesn't cover, but as now we have the test, we can refactor in the future.

[dai-shi]

Size Change: +84 B (+0.1%)

Total Size: 87 kB

Filename	Size	Change
./dist/esm/vanilla.mjs	3.83 kB	+14 B (+0.37%)
./dist/system/vanilla.development.js	3.92 kB	+14 B (+0.36%)
./dist/system/vanilla.production.js	2.06 kB	+11 B (+0.54%)
./dist/umd/vanilla.development.js	4.91 kB	+17 B (+0.35%)
./dist/umd/vanilla.production.js	2.69 kB	+12 B (+0.45%)
./dist/vanilla.js	4.81 kB	+16 B (+0.33%)

ℹ️ View Unchanged

Filename	Size
./dist/babel/plugin-debug-label.js	932 B
./dist/babel/plugin-react-refresh.js	1.14 kB
./dist/babel/preset.js	1.41 kB
./dist/esm/babel/plugin-debug-label.mjs	1 kB
./dist/esm/babel/plugin-react-refresh.mjs	1.19 kB
./dist/esm/babel/preset.mjs	1.49 kB
./dist/esm/index.mjs	62 B
./dist/esm/react.mjs	1.02 kB
./dist/esm/react/utils.mjs	746 B
./dist/esm/utils.mjs	67 B
./dist/esm/vanilla/utils.mjs	4.95 kB
./dist/index.js	242 B
./dist/react.js	1.06 kB
./dist/react/utils.js	1.39 kB
./dist/system/babel/plugin-debug-label.development.js	1.1 kB
./dist/system/babel/plugin-debug-label.production.js	775 B
./dist/system/babel/plugin-react-refresh.development.js	1.29 kB
./dist/system/babel/plugin-react-refresh.production.js	928 B
./dist/system/babel/preset.development.js	1.59 kB
./dist/system/babel/preset.production.js	1.14 kB
./dist/system/index.development.js	252 B
./dist/system/index.production.js	183 B
./dist/system/react.development.js	1.17 kB
./dist/system/react.production.js	715 B
./dist/system/react/utils.development.js	860 B
./dist/system/react/utils.production.js	462 B
./dist/system/utils.development.js	257 B
./dist/system/utils.production.js	187 B
./dist/system/vanilla/utils.development.js	5.16 kB
./dist/system/vanilla/utils.production.js	3.09 kB
./dist/umd/babel/plugin-debug-label.development.js	1.08 kB
./dist/umd/babel/plugin-debug-label.production.js	852 B
./dist/umd/babel/plugin-react-refresh.development.js	1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js	1 kB
./dist/umd/babel/preset.development.js	1.54 kB
./dist/umd/babel/preset.production.js	1.22 kB
./dist/umd/index.development.js	383 B
./dist/umd/index.production.js	328 B
./dist/umd/react.development.js	1.18 kB
./dist/umd/react.production.js	786 B
./dist/umd/react/utils.development.js	1.53 kB
./dist/umd/react/utils.production.js	1.01 kB
./dist/umd/utils.development.js	399 B
./dist/umd/utils.production.js	342 B
./dist/umd/vanilla/utils.development.js	6.07 kB
./dist/umd/vanilla/utils.production.js	3.72 kB
./dist/utils.js	247 B
./dist/vanilla/utils.js	5.94 kB

_{compressed-size-action}