Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(atom-with-broadcast): update example code to work with TypeScript #2716

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

hoangvu12
Copy link
Contributor

Related Bug Reports or Discussions

None

Summary

  • The old code used the library's old TypeScript API. This update fixes it.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 9:46am

Copy link

codesandbox-ci bot commented Aug 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

LiveCodes Preview in LiveCodes

Latest commit: 3dafee2
Last updated: Aug 28, 2024 9:45am (UTC)

Playground Link
React demo https://livecodes.io?x=id/EXJH2EE7W

See documentations for usage instructions.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution!

If you find anything else in docs to improve, feel free to send PRs.

@dai-shi dai-shi merged commit 1deb5e0 into pmndrs:main Aug 28, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants