Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Leva): disable dev warning #399

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

CodyJasonBennett
Copy link
Member

Resolves #358, semver patch alternative to #330.

Disables React 18 deprecation warnings when creating a legacy root.

ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it’s running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: ac204af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
leva Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leva ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 7:21AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ac204af:

Sandbox Source
leva-minimal Configuration
leva-busy Configuration
leva-scroll Configuration
leva-advanced-panels Configuration
leva-ui Configuration
leva-theme Configuration
leva-transient Configuration
leva-plugin-plot Configuration
leva-plugin-bezier Configuration
leva-plugin-spring Configuration
leva-plugin-dates Configuration
leva-custom-plugin Configuration

@RodrigoHamuy
Copy link
Contributor

I found out the error was on my side, maybe? I was using vitest and needed to pass --dom. After that Leva stop throwing errors. So I'm tempted to close this PR unless that anybody else finds it useful?

@dbismut
Copy link
Collaborator

dbismut commented Oct 28, 2022

@CodyJasonBennett let's do this otherwise @drcmda will nag me forever.

@dbismut dbismut merged commit 01eb144 into pmndrs:main Oct 28, 2022
@CodyJasonBennett CodyJasonBennett deleted the fix/disable-deprecation-warning branch October 28, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18 support ?
3 participants