Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] refactor: utils #2899

Closed
wants to merge 2 commits into from
Closed

[v9] refactor: utils #2899

wants to merge 2 commits into from

Conversation

krispya
Copy link
Member

@krispya krispya commented Jun 21, 2023

This PR splits up the monolithic utils file into smaller ones organized by type and fixes some dependency issues by importing anything to do with the reconciler last.

@krispya krispya changed the title refactor: utils [v9] refactor: utils Jun 21, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a2b9ed:

Sandbox Source
example Configuration

# Conflicts:
#	packages/fiber/src/core/reconciler.ts
#	packages/fiber/src/core/utils.tsx
@krispya
Copy link
Member Author

krispya commented Jun 21, 2023

I missed that now was already inlined. So I'll let this be here for merging if people prefer the organizing. (Which I do.) This version doesn't require inlining.

@CodyJasonBennett
Copy link
Member

This should wait until v9 beta where we can feature freeze v8.

@CodyJasonBennett
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants