[v4-experimental] use mutable source (#157) #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: new implementation with useMutableSource * fix: support slice to be null * [v3-alpha] clean up types * shave two bytes * revert type hack for immer * update size snapshot * [v3-alpha] unified api * shave a byte * v4-alpha * update size snapshot * revert skipped test * fix test for uMS * fix typo
|
I don't think we should merge this into master while experimental. Converted back to draft. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3cfc89:
|
|
A counter example: |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40bbf05:
|
This was referenced Feb 6, 2021
Closed
|
closing in favor of #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: new implementation with useMutableSource
fix: support slice to be null
[v3-alpha] clean up types
shave two bytes
revert type hack for immer
update size snapshot
[v3-alpha] unified api
shave a byte
v4-alpha
update size snapshot
revert skipped test
fix test for uMS
fix typo