Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useStore uses ReadonlyStoreApi #2586

Merged
merged 3 commits into from
Jun 26, 2024
Merged

useStore uses ReadonlyStoreApi #2586

merged 3 commits into from
Jun 26, 2024

Conversation

holic
Copy link
Contributor

@holic holic commented Jun 5, 2024 •
edited
Loading

Related Issues or Discussions

Fixes #2581

Summary

UseBoundStore types were relaxed in #1589 because the internals of this method did not use any of the setters, only getters. We can also do this for useStore types because its API only uses getters.

Context: I am building a library that returns a store API with only getter methods exposed and I would like folks to be able to pass this directly into Zustand's useStore React helper.

Check List

  • pnpm run prettier for formatting code and docs

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 2:36am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@holic
Copy link
Contributor Author

holic commented Jun 5, 2024

Let me know if you want me to open a similar PR targeting the v5 branch.

dai-shi
dai-shi approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think I can take care of the rest. Thanks for your contribution!

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 20, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi added this to the v4.5.3 milestone Jun 26, 2024
@dai-shi dai-shi merged commit a262c9f into pmndrs:main Jun 26, 2024
39 checks passed
@nouhaila49 nouhaila49 mentioned this pull request Jul 17, 2024
Closed
@kdsfkls kdsfkls mentioned this pull request Jul 17, 2024
Closed
@VladDudarenko VladDudarenko mentioned this pull request Jul 17, 2024
Closed
@zainaboladiti zainaboladiti mentioned this pull request Jul 17, 2024
Open
@AnnaTalan AnnaTalan mentioned this pull request Jul 17, 2024
Closed
@Sameer515 Sameer515 mentioned this pull request Jul 17, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 17, 2024
Open
@hunorszegediblack hunorszegediblack mentioned this pull request Jul 19, 2024
Open
@mewph mewph mentioned this pull request Jul 19, 2024
Open
@salzateatfluid salzateatfluid mentioned this pull request Jul 20, 2024
Closed
@bsd33bond bsd33bond mentioned this pull request Jul 20, 2024
Closed
@boduk000 boduk000 mentioned this pull request Jul 20, 2024
Closed
@basakerdogan basakerdogan mentioned this pull request Jul 24, 2024
Open
@luciano-mori luciano-mori mentioned this pull request Jul 24, 2024
Open
@gkchaitu63 gkchaitu63 mentioned this pull request Jul 30, 2024
Open
@jones58 jones58 mentioned this pull request Jul 30, 2024
Merged
@g00b g00b mentioned this pull request Jul 31, 2024
Closed
@hzdai0 hzdai0 mentioned this pull request Oct 6, 2024
Open
@jellyjams7 jellyjams7 mentioned this pull request Oct 6, 2024
Open
@tpaec01 tpaec01 mentioned this pull request Oct 6, 2024
Open
@blake91399 blake91399 mentioned this pull request Oct 6, 2024
Open
@Yes-Yes-Ye Yes-Yes-Ye mentioned this pull request Oct 6, 2024
Open
@joeltmenayathil joeltmenayathil mentioned this pull request Oct 6, 2024
Open
@gregdo21 gregdo21 mentioned this pull request Oct 9, 2024
Open
@voliverosv voliverosv mentioned this pull request Oct 19, 2024
Open
@Deus-Dox Deus-Dox mentioned this pull request Oct 19, 2024
Open
@pb-snyk pb-snyk mentioned this pull request Oct 20, 2024
Open
@FRA-37 FRA-37 mentioned this pull request Oct 23, 2024
Open
@kdsfkls kdsfkls mentioned this pull request Oct 23, 2024
Open
@skiiipy69 skiiipy69 mentioned this pull request Oct 26, 2024
Open
@shravyagoli26 shravyagoli26 mentioned this pull request Oct 26, 2024
Open
@Ilyas-snyk Ilyas-snyk mentioned this pull request Oct 27, 2024
Open
@VladDudarenko VladDudarenko mentioned this pull request Oct 27, 2024
Open
@snowsky snowsky mentioned this pull request Oct 28, 2024
Open
@saadawan-eng saadawan-eng mentioned this pull request Oct 29, 2024
Open
@nouhaila49 nouhaila49 mentioned this pull request Oct 30, 2024
Open
@foolcardssk foolcardssk mentioned this pull request Oct 30, 2024
Open
@thiagarajanb thiagarajanb mentioned this pull request Oct 30, 2024
Open
@Harshith5346 Harshith5346 mentioned this pull request Oct 31, 2024
Open
@cgonzo98 cgonzo98 mentioned this pull request Nov 1, 2024
Open
@realgoob realgoob mentioned this pull request Nov 1, 2024
Open
@elizabethtl elizabethtl mentioned this pull request Nov 4, 2024
Open
@prestokp prestokp mentioned this pull request Nov 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Nov 5, 2024
Open
@ritwiksaha98 ritwiksaha98 mentioned this pull request Nov 7, 2024
Open
@dunningdan dunningdan mentioned this pull request Nov 8, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@holic @dai-shi