hydra: refactor kvs and fix duplicate keys #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
test:mpich/ch3/tcp ✔️ |
|
test:mpich/pmi ✔️ |
|
Do we want to also incorporate this change while we are at it? #5370 |
Sure. Let me pick that PR. |
Refactor kvs to hide internals in lib/pmiserv_common.c. Always add new key pair to the head, so that we always find the latest key pair in the case of duplicate keys. Although PMI require users to not put duplicate keys, this fix makes the behavior more expected. Note: this fixes the session_re_init test. Session reinit skips PMI_Finalize between sessions. The proper fix should introduce new API e.g. PMI_KVS_Clear. For now, we'll simply make the later key overwrite the previous duplicates.
Shorten it to HYD_kvs_.
Since now we only call PMIx_Finalize once in the at exit handler, we need make sure that we only call PMIx_Init once. Otherwise, the openpmix server may complain abnormal exit.
|
test:mpich/pmi |
4 tasks
This was referenced Jun 22, 2023
raffenet
approved these changes
Jun 23, 2023
sonjahapp
reviewed
Jul 19, 2023
| @@ -137,25 +156,18 @@ HYD_status HYD_pmcd_pmi_add_kvs(const char *key, const char *val, struct HYD_pmc | |||
|
|
|||
| if (kvs->key_pair == NULL) { | |||
| kvs->key_pair = key_pair; | |||
| kvs->tail = key_pair; | |||
| } else { | |||
| #ifdef PMI_KEY_CHECK | |||
There was a problem hiding this comment.
Do you think it would make sense to enable duplicate keys also with debugging of MPICH/ hydra enabled, e.g., by changing the PMI_KEY_CHECK into a debug message of hydra for duplicate keys instead of an error?
There was a problem hiding this comment.
Yes, it makes sense. Do you want to make a PR for it?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Refactor kvs to hide internals in lib/pmiserv_common.c.
Always add new keypair to the head, so that we always find the latest
key pair in the case of duplicate keys. Although PMI require users to
not put duplicate keys, this fix makes the behavior more expected.
Note: this fixes the session_re_init test. Session reinit skips
PMI_Finalize between sessions. The proper fix should introduce new API
e.g. PMI_KVS_Clear. For now, we'll simply make the later key overwirte
the previous duplicates.
Also rename the
HYD_pmcd_pmi_kvs_prefix toHYD_kvs_Fixes #6446
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.