build: Move benchmark generation to test/mpi/autogen.sh #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
requested changes
Oct 9, 2024
| export PERL5LIB=$MYDEF_BOOT/lib/perl5 | ||
| export MYDEFLIB=$MYDEF_BOOT/lib/MyDef | ||
| (cd bench && ./autogen.sh) | ||
| } |
There was a problem hiding this comment.
The concern is that the user may only download the testsuite tarball and this make the autogen broken. How about protecting it with -
if test -d `$MYDEF_BOOT` ; then
export PATH=$MYDEF_BOOT/bin:$PATH
export PERL5LIB=$MYDEF_BOOT/lib/perl5
export MYDEFLIB=$MYDEF_BOOT/lib/MyDef
fi
MyDef is essentially a dependency. User (like me) always can install MyDef in his system then autogen.sh will always work.
test/mpi/autogen.sh
Outdated
| @@ -78,6 +86,9 @@ if test ! -e include/mtest_mpix.h ; then | |||
| touch include/mtest_mpix.h | |||
| fi | |||
|
|
|||
| # Create the benchmark tests | |||
| create_benchmarks | |||
There was a problem hiding this comment.
How about rename it to "generate_benchmarks"?
These are only needed by the testsuite. If mydef is unavailable for some reason, e.g. running autogen.sh from a testsuite-only tarball, regeneration of the benchmarks will be skipped.
|
test:mpich/ch4/most |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
These are only needed by the testsuite.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.