Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fails: No rule for target READMEmd #30

Closed
johannessen opened this issue Feb 19, 2024 · 5 comments
Closed

make fails: No rule for target READMEmd #30

johannessen opened this issue Feb 19, 2024 · 5 comments
Assignees

Comments

@johannessen
Copy link

Installing Compress-Raw-Zlib-2.207.tar.gz from CPAN fails, possibly due to a5e8a4e:

$ perl Makefile.PL 
Parsing config.in...
Building Zlib is enabled
Auto Detect Gzip OS Code..
Setting Gzip OS Code to 3 [Unix/Default]
Looks Good.
Up/Downgrade not needed.
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Compress::Raw::Zlib
Writing MYMETA.yml and MYMETA.json
$ make
cp lib/Compress/Raw/Zlib.pm blib/lib/Compress/Raw/Zlib.pm
Running Mkbootstrap for Zlib ()
chmod 644 "Zlib.bs"
"/Users/aj/.perlbrew/perls/perl-5.38.0/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Zlib.bs blib/arch/auto/Compress/Raw/Zlib/Zlib.bs 644
"/Users/aj/.perlbrew/perls/perl-5.38.0/bin/perl" "/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/ExtUtils/xsubpp"  -typemap '/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/ExtUtils/typemap' -typemap '/Users/aj/Compress-Raw-Zlib-2.207/typemap'  Zlib.xs > Zlib.xsc
mv Zlib.xsc Zlib.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= Zlib.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= adler32.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= compress.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= crc32.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= deflate.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= infback.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= inffast.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= inflate.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= inftrees.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= trees.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= uncompr.c
cc -c  -I./zlib-src -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -Wno-error=implicit-function-declaration -O3   -DVERSION=\"2.207\" -DXS_VERSION=\"2.207\"  "-I/Users/aj/.perlbrew/perls/perl-5.38.0/lib/5.38.0/darwin-ld-2level/CORE"  -DNO_VIZ -DZ_SOLO   -DZ_PREFIX  -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=1 -Dregister= zutil.c
rm -f blib/arch/auto/Compress/Raw/Zlib/Zlib.bundle
cc  -mmacosx-version-min=10.15 -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector-strong  Zlib.o adler32.o compress.o crc32.o deflate.o infback.o inffast.o inflate.o inftrees.o trees.o uncompr.o zutil.o   -o blib/arch/auto/Compress/Raw/Zlib/Zlib.bundle  \
	      \
	  
chmod 755 blib/arch/auto/Compress/Raw/Zlib/Zlib.bundle
make: *** No rule to make target `READMEmd', needed by `manifypods'.  Stop.
@pmqs pmqs self-assigned this Feb 19, 2024
@pmqs
Copy link
Owner

pmqs commented Feb 19, 2024

Thanks @johannessen

the READMEmd target was added in the change I added yesterday for 2.207.

I don't see the error you are getting on my Linux dev setup, so I assume there must be something different about how a Mac build works.

If you have the time could you try editing private/MakeUtil.pm and add the else block .

    if (-e '.github' && exists $params{name})
    {
        my $name = $params{name};
        $postamble .= <<"EOM";

READMEmd: .github/$name.pod

.github/$name.pod: lib/Compress/Raw/$name.pm
	\@echo Creating .github/$name.pod from $name.pm
	\$(NOECHO) perl -ne 'print unless 1 .. /^__END__/' lib/Compress/Raw/$name.pm >.github/$name.pod

EOM
    }
    # ADD THIS ELSE BLOCK
    else
    {
        $postamble .= <<"EOM";

READMEmd: 

EOM
    }

@johannessen
Copy link
Author

Actually I first got this issue in a Linux GH action, so macOS is unlikely to be the culprit here.

I suspect your dev setup either has PERL_CORE set or has a .github directory present. From reading the commit I mentioned earlier, it looks like either of these things would prevent you from seeing this particular issue.

With the else block added, make and make test succeed.

@pmqs
Copy link
Owner

pmqs commented Feb 19, 2024

Actually I first got this issue in a Linux GH action, so macOS is unlikely to be the culprit here.

I test this module in a series of GH workflows without a problem (although they will have the .github directory.)

I suspect your dev setup either has PERL_CORE set or has a .github directory present. From reading the commit I mentioned earlier, it looks like either of these things would prevent you from seeing this particular issue.

No, I've deliberately build the module away from my dev source tree, so no .github directory is present. Also, don't have PERL_CORE set.

With the else block added, make and make test succeed.

Thanks for testing that out for me.

pmqs added a commit that referenced this issue Feb 19, 2024
@johannessen
Copy link
Author

No, I've deliberately build the module away from my dev source tree, so no .github directory is present. Also, don't have PERL_CORE set.

Interesting. In that case, I don't know why it was failing for me, but not for you.

Thanks for testing that out for me.

No problem. Thanks for looking into it!

@johannessen
Copy link
Author

2.208 resolves the issue. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants