Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libz Symbol correction PR w/ perl_crz_ symbols #11

Merged
merged 2 commits into from
May 13, 2022

Conversation

monkburger
Copy link

@monkburger monkburger commented May 3, 2022

This is a slightly different way to fix #8 (Thanks to @toddr for the suggestion)

This enables -DZ_PREFIX, but prefixes external symbols with perl_crz_ instead of z_ (only when building w/ -DZ_PREFIX)

make test passes, and the symbols show the following, ie:

57: 000000000000d780   275 FUNC    GLOBAL DEFAULT   14 perl_crz_crc32_z
   59: 0000000000017000   301 FUNC    GLOBAL DEFAULT   14 perl_crz__tr_stored_block
   60: 0000000000015530    70 FUNC    GLOBAL DEFAULT   14 perl_crz_inflateUndermine
   61: 0000000000012ee0   192 FUNC    GLOBAL DEFAULT   14 perl_crz_inflateInit2_
   62: 000000000001bae0   512 OBJECT  GLOBAL DEFAULT   16 perl_crz__dist_code
   63: 0000000000012e10   198 FUNC    GLOBAL DEFAULT   14 perl_crz_inflateReset2
   64: 000000000000d0a0  1142 FUNC    GLOBAL DEFAULT   14 perl_crz_adler32_z
   65: 000000000001a320    69 OBJECT  GLOBAL DEFAULT   16 perl_crz_deflate_copyrigh
   67: 000000000000d8b0    90 FUNC    GLOBAL DEFAULT   14 perl_crz_crc32_combine64
   69: 000000000000f4f0    62 FUNC    GLOBAL DEFAULT   14 perl_crz_deflateSetHeader
   70: 000000000000f530    86 FUNC    GLOBAL DEFAULT   14 perl_crz_deflatePending

Gary Stanley added 2 commits May 3, 2022 18:06
This enables -DZ_PREFIX, but prefixes external symbols with perl_crz_ instead of z_ (only when building w/ -DZ_PREFIX)
@pmqs pmqs self-assigned this May 3, 2022
@pmqs pmqs merged commit 64aea2d into pmqs:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress::Raw::Zlib doesn't apply symbol versioning when building zlib-src
2 participants