node18 is not a valid run.uses value

[garrytrinder]

In actions.yml we reference node18, but this breaks the yaml schema validation.

https://github.com/pnp/action-cli-login/blob/dda9848b627844079f147a5291963140eac9c28b/action.yml#L26C18-L26C18

runs.uses should be either node12 or node16.

Schema https://json.schemastore.org/github-action.json

/cc @milanholemans apologies, I missed this in the review 😞

[milanholemans]

That's a shame. Is there no way for us to let it run using Node18? Since the CLI requires Node18 as a minimum, it doesn't seem logical to leave this on Node16.

Can't we use actions/setup-node@v3 to setup our own Node version?

[garrytrinder]

Since the CLI requires Node18 as a minimum, it doesn't seem logical to leave this on Node16.

IIRC, you can run the CLI on node@16 just fine, but node@18 is required for development of the CLI.

Can't we use actions/setup-node@v3 to setup our own Node version?

I don't think this is relevant in this context. The action.yml represents the metadata of the action, it is not a GitHub workflow.

[milanholemans]

IIRC, you can run the CLI on node@16 just fine, but node@18 is required for development of the CLI.

Not only for development but also to use the CLI. It's possible that it works on Node16, but there is no guarantee since we don't test anything on Node16 anymore.

https://pnp.github.io/cli-microsoft365/user-guide/installing-cli#prerequisites

[garrytrinder]

Thanks for clarifying.

As you can see I’ve reverted the change to resolve the validation error.

If using node@16 becomes an issue, then we should maybe look to move to Docker style actions where we can define the runtime environment to our needs.

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action#creating-a-dockerfile

[garrytrinder]

node12 is going away and the only option will be node16

https://github.blog/changelog/2023-07-17-github-actions-removal-of-node12-from-the-actions-runner/

Also, we should track this issue actions/runner#2619 which is asking for latest node support.

[milanholemans]

https://github.com/orgs/community/discussions/53217#discussioncomment-6227341

This might work.