Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Viva Connections creates a second pages library, breaking site pages detection #3710

Closed
6 tasks
nils-a opened this issue Jan 26, 2024 · 1 comment · Fixed by #3713
Closed
6 tasks
Labels
bug Something isn't working

Comments

@nils-a
Copy link

nils-a commented Jan 26, 2024

Expected behavior

The PagesUtility contains code to find the "site pages" library.
I would expect this code to find the "site pages".

Actual behavior

This code might fail or target the wrong library, for sites that have Viva connections created "Announcements" library.

Steps to reproduce behavior

The same or similar code was modified in pnp/pnpframework#975 and pnp/pnpcore@0ea1c82

What is the version of the Cmdlet module you are running?

I looked at the current version:

if (list.IsPropertyAvailable(p => p.Fields) && list.Fields.AsRequested().FirstOrDefault(p => p.InternalName == "CanvasContent1") != null)
{
pagesLibrary = list;
break;
}

Which operating system/environment are you running PnP PowerShell on?

  • Windows
  • Linux
  • MacOS
  • Azure Cloud Shell
  • Azure Functions
  • Other : please specify
@nils-a nils-a added the bug Something isn't working label Jan 26, 2024
gautamdsheth pushed a commit to gautamdsheth/powershell that referenced this issue Jan 28, 2024
gautamdsheth added a commit that referenced this issue Jan 28, 2024
@gautamdsheth
Copy link
Collaborator

Hi @nils-a , have fixed this. It was used in Enable/Disable-PnPPageScheduling cmdlets.
Will be available in tomorrow's nightly builds.

Thanks for raising the issue and sharing the fix with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants