Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference ouifr statically instead of dynamic. #105

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Reference ouifr statically instead of dynamic. #105

merged 1 commit into from
Aug 9, 2018

Conversation

wobba
Copy link
Contributor

@wobba wobba commented Aug 6, 2018

Q A
Bug fix? [x]

What's in this Pull Request?

Refernce Office UI Fabric statically instead of dynamically to ensure only what is used is loaded/included.

Include only those parts which are needed on build
@codecov-io
Copy link

Codecov Report

Merging #105 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #105   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       78           
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3358fc...b563d2f. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Aug 9, 2018

Thanks @wobba for the fix!

@estruyf estruyf deleted the ouif-static branch August 9, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants