Use anchor id from taxonomyfield in dynamicform #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because the word "laufzeit" in german means "running time" in english! "Knoten" now refers to the "node" of the termstore
This reverts commit d268c09.
SmarterJB
changed the title
…namicform # Conflicts: # src/controls/dynamicForm/DynamicForm.tsx
|
@SmarterJB sorry for the delay on this. Can you please review the conflicts? |
|
No problem! I resolved the conflicts! |
|
Hello @joelfmrodrigues can this be included in the next release aswell? Then all my current issues should be fixed! Cheers! |
|
Sorry, 3.11.0 was just published some minutes ago (should have been 2 days ago but there was an issue publishing it to npm) |
|
okay no problem! we can work with the beta version once this is through! Thanks for the quick response! :) |
AJIXuMuK
requested changes
Nov 4, 2022
| @@ -28,8 +28,6 @@ export default class SPTermStorePickerService { | |||
| * Service constructor | |||
| */ | |||
| constructor(private props: ITaxonomyPickerProps, private context: BaseComponentContext) { | |||
| this.clientServiceUrl = this.context.pageContext.web.absoluteUrl + '/_vti_bin/client.svc/ProcessQuery'; | |||
There was a problem hiding this comment.
this change is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This change allows the dynamic form to use the anchor id which is set in the field settings of the taxonomy field. I also changed the wording of the german localization because the word "Laufzeit" in german means "running time" in english! "Knoten" now refers to the "node" of the termstore which is more suiting in my opinion.
This is both a bugfix (because when I used the dynamic form, I wondered why it isnt working) and a new feature!