Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb nav #1368 #1458

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix breadcrumb nav #1368 #1458

merged 2 commits into from
Feb 21, 2023

Conversation

SamueleFurnari
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? #1368, improve #1447

What's in this Pull Request?

Fix for breadcrumb navigation on SiteFilePicketTab. Compared to #1447 I've replaced the strict comparison woth a compare based on value.

@joaojmendes
Copy link
Collaborator

@SamueleFurnari , thank you for the PR , but seems we have a conflicts on file, can you check please ? Thank you!

@joaojmendes joaojmendes self-requested a review February 20, 2023 22:12
@joaojmendes joaojmendes added this to the 3.13.0 milestone Feb 20, 2023
@SamueleFurnari
Copy link
Contributor Author

@joaojmendes i've fixed the conflict. Thanks for the great job!

@joaojmendes joaojmendes merged commit 4ebe579 into pnp:dev Feb 21, 2023
@joaojmendes
Copy link
Collaborator

@SamueleFurnari,thank you for the fix

@SamueleFurnari SamueleFurnari deleted the fix_breadcrumb_nav branch February 22, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants