Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New control - Maps and also adding "ExtensionContext" to PeoplePicker and List Cntrol #186

Merged
merged 3 commits into from
Dec 7, 2018

Conversation

anoopt
Copy link
Member

@anoopt anoopt commented Nov 21, 2018

Q A
Bug fix? [ ]
New feature? [X ]
New sample? [X ]
Related issues? NA

What's in this Pull Request?

1. Added a new control called "Maps" as a response to #14

The current version of the submitted PR, accepts co-ordinates (latitude and longitude) as properties and displays OpenStreetMap for the co-ordinates.
The plan is to add "city search" in the upcoming weeks and use Google's geocode service to get co-ordinates for the entered city. This will need API key (which is free only for some queries and after that would need billing enabled for premium services).

Default Maps control (with co-ordinates set to London)

Default Maps control

Maps control with search

Maps control with search

2. Added "ExtensionContext" reference in ListPicker and PeoplePicker controls.

There are times when we would need to use these controls in SPFx extensions as well. Hence I have added the reference to "ExtensionContext" in these controls and the context in these controls can now be of the type "WebPartContext" or "ExtensionContext".

context: WebPartContext | ExtensionContext;

Sharing is caring

@codecov-io
Copy link

Codecov Report

Merging #186 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #186   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a903091...bc56c98. Read the comment docs.

@estruyf estruyf merged commit bc56c98 into pnp:dev Dec 7, 2018
@estruyf
Copy link
Member

estruyf commented Dec 7, 2018

Thanks @anoopt, your map control has been merged to the DEV branch and will be available in version 1.11.0.

I have also applied a couple of code changes for consistency, but also got rid of the Bing API.

@anoopt
Copy link
Member Author

anoopt commented Dec 7, 2018

Thank you @estruyf for the code update and consistency. TIL we can get the co-ordinates using "https://nominatim.openstreetmap.org".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants