Minutes and Seconds validation #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.0.0 to 3.6.5. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/commits) Signed-off-by: dependabot[bot] <[email protected]>
…ov-3.6.5 Bump codecov from 3.0.0 to 3.6.5
|
|
Codecov Report
@@ Coverage Diff @@
## dev #496 +/- ##
=======================================
Coverage 73.31% 73.31%
=======================================
Files 18 18
Lines 802 802
Branches 164 164
=======================================
Hits 588 588
Misses 164 164
Partials 50 50
Continue to review full report at Codecov.
|
|
Thanks @Leomaradan for that change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Added a validation for MinutesComponent and SecondsComponent, that use the same syntax/behavior than in HoursComponent (The picker will return the last valid date if typing invalid minute or second value).