Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options for ListItemPicker (substringof search) and ListItemAttachments (open in new window) #584

Merged
merged 7 commits into from
Jul 7, 2020
Merged

Options for ListItemPicker (substringof search) and ListItemAttachments (open in new window) #584

merged 7 commits into from
Jul 7, 2020

Conversation

joeljeffery
Copy link
Contributor

@joeljeffery joeljeffery commented Jun 13, 2020 •
edited
Loading

Q A
Bug fix? [X ]
New feature? [X ]
New sample? [ ]
Related issues? fixes #582, fixes #583, fixes #585, fixes #586

What's in this Pull Request?

Four changes:
ListItemPicker - option to search by substring

  • added substringSearch?:boolean prop
  • added substringSearch:boolean = false parameter to SPService.getListItems
  • added substringOf as optional search strategy to SPService.getListItems

ListItemAttachments - option to open attachments in new window to support use from Microsoft Teams

  • added openAttachmentsInNewWindow?: boolean prop
  • added onClick handler window.open(${file.ServerRelativeUrl}?web=1, "_blank")

Map - return display name and address details along with coordinates

  • added address: any to LocationInfo interface
  • added address and displayname fields to ICoordinates interface
  • added &addressdetails=1 parameter to nominatim call
  • added returned display_name and address from nominatim data as displayname and address fields on coordinates object returned from map
  • added type to coordinates object passed to onUpdateCoordinates() in _getCoordinates()
  • added support for zoom levels beyond 15

Map - added rudimentary support for Bing maps

  • added alternative _getBingMapUrl method to return suitable draggable or static bing.com/maps/embed link (no API key required)
  • added pushpin indicator icon for Bing static (non-draggable) map to centre of map

Joel Jeffery
w:joelblogs.co.uk
t:@joelblogs

@AJIXuMuK
Copy link
Collaborator

Hi @joeljeffery!
Thank you for all the changes!

I've added some comments to check.

And it would be also great if you merge with dev first as there are conflicts right now.

@AJIXuMuK AJIXuMuK merged commit 56b0505 into pnp:dev Jul 7, 2020
AJIXuMuK
AJIXuMuK approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@AJIXuMuK AJIXuMuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved all the issues

src/controls/map/Map.tsx Show resolved Hide resolved
src/controls/map/Map.tsx Show resolved Hide resolved
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 7, 2020

@joeljeffery - thank you for the changes. I have resolved the issues and conflicts and merged the PR.

@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Jul 7, 2020
@joeljeffery
Copy link
Contributor Author

And it would be also great if you merge with dev first as there are conflicts right now.

Thanks @AJIXuMuK for rolling my changes in!

I'll be sure to use the dev branch next time! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJIXuMuK AJIXuMuK AJIXuMuK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joeljeffery @AJIXuMuK @estruyf