Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky header on ListView #693

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Sticky header on ListView #693

merged 2 commits into from
Oct 12, 2020

Conversation

Abderahman88
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [ X]
New sample? [ ]
Related issues? mentioned in #634

What's in this Pull Request?

Added the ability of a fixed header. (https://developer.microsoft.com/en-us/fluentui#/controls/web/scrollablepane)
Both searchbox and headers stay locked during scrolling.

Property added:

  • stickyHeader (boolean - default false) => Show fixed headers.

Remarque:

  • Scrollable pane has a fixed height.

sticky_header

@AJIXuMuK AJIXuMuK merged commit 00cb86e into pnp:dev Oct 12, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @Abderahman88 for the enhancement!
It has been merged with some small changes

@AJIXuMuK AJIXuMuK added this to the 2.1.0 milestone Oct 12, 2020
@aaclage
Copy link
Contributor

aaclage commented Oct 13, 2020

Hi @AJIXuMuK,

This last change also change the height to have a strange behavior, this was expected?

image

@Abderahman88
Copy link
Contributor Author

Hi @aaclage ,

This is (at the moment) the expected behaviour if the stickyHeader-property is set to true.

StickyPropTrue

fixedHeight

If the stickyHeader-property is set to false, it behaves as before.

StickyPropFalse

dynamicHeight

This is a small downside to this feature.

Another possible approach would be adding a pagination-footer.

@aaclage
Copy link
Contributor

aaclage commented Oct 13, 2020

I am looking that height is max-height=50vh and initially appear with minimal and only grow to the max.
This way will appear more user friendly.

@aaclage
Copy link
Contributor

aaclage commented Oct 13, 2020

@Abderahman88
Follow up PR #696

@Abderahman88
Copy link
Contributor Author

Nice work! @aaclage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants