-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Control MyTeams #874
New Control MyTeams #874
Conversation
@joaojmendes many thanks for the PR, awesome control! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joaojmendes for the addition to the library!
Could you please look into my comments? And also merge with the latest dev
to remove the release
folder from the git
@AJIXuMuK many thanks, I did the changes. Thank you very much. |
import pullAllBy from "lodash/pullAllBy"; | ||
import find from "lodash/find"; | ||
import { ImageIcon } from "office-ui-fabric-react/lib/Icon"; | ||
import { Customizer } from "office-ui-fabric-react/lib/Utilities"; | ||
const pickerSuggestionsProps: IBasePickerSuggestionsProps = { | ||
suggestionsHeaderText: "Suggested Teams", | ||
noResultsFoundText: "No Teams found", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaojmendes loc strings please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hi @joelfmrodrigues thank you very much , I did the changes , please tell me if everything is ok now. :) |
}} | ||
itemLimit={itemLimit ?? undefined} | ||
onChange={(items) => { | ||
dispatch({ type: "UPDATE_SELECTEITEM", payload: items }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaojmendes did you miss this one?
src/loc/bg-bg.ts
Outdated
MyTeamsTeamChannelTypeMessage: "Private Channels", | ||
TeamChannelPickerFontIconFavoriteText: "Favorite", | ||
TeamChannelPickerFontIconPrivateChannelTitle: "Private Channel", | ||
TeamChannelPickerSugestionHeaderText: " \"Suggested Team Channels\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double quote escaping, possibly caused by a VS code extension? Applies to other languages as well
New Control MyTeams