Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Control MyTeams #874

Merged
merged 17 commits into from
May 3, 2021
Merged

New Control MyTeams #874

merged 17 commits into from
May 3, 2021

Conversation

joaojmendes
Copy link
Collaborator

New Control MyTeams

@joelfmrodrigues
Copy link
Collaborator

@joaojmendes many thanks for the PR, awesome control!
The PR is fairly big so may take some time to review. Please be patient :)

Copy link
Collaborator

@AJIXuMuK AJIXuMuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joaojmendes for the addition to the library!
Could you please look into my comments? And also merge with the latest dev to remove the release folder from the git

src/common/model/EMembersipType.ts Outdated Show resolved Hide resolved
src/common/model/ITeamChannel copy.ts Outdated Show resolved Hide resolved
src/controls/MyTeams/IMyTeamsProps.ts Outdated Show resolved Hide resolved
src/controls/MyTeams/components/Team/Team.tsx Outdated Show resolved Hide resolved
src/controls/TeamPicker/TeamPickerStyles.ts Show resolved Hide resolved
@joaojmendes
Copy link
Collaborator Author

@AJIXuMuK many thanks, I did the changes. Thank you very much.

src/loc/pt-pt.ts Outdated Show resolved Hide resolved
import pullAllBy from "lodash/pullAllBy";
import find from "lodash/find";
import { ImageIcon } from "office-ui-fabric-react/lib/Icon";
import { Customizer } from "office-ui-fabric-react/lib/Utilities";
const pickerSuggestionsProps: IBasePickerSuggestionsProps = {
suggestionsHeaderText: "Suggested Teams",
noResultsFoundText: "No Teams found",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaojmendes loc strings please

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/loc/en-us.ts Outdated Show resolved Hide resolved
src/loc/pt-pt.ts Outdated Show resolved Hide resolved
@joaojmendes
Copy link
Collaborator Author

Hi @joelfmrodrigues thank you very much , I did the changes , please tell me if everything is ok now. :)

}}
itemLimit={itemLimit ?? undefined}
onChange={(items) => {
dispatch({ type: "UPDATE_SELECTEITEM", payload: items });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaojmendes did you miss this one?

src/loc/bg-bg.ts Outdated
MyTeamsTeamChannelTypeMessage: "Private Channels",
TeamChannelPickerFontIconFavoriteText: "Favorite",
TeamChannelPickerFontIconPrivateChannelTitle: "Private Channel",
TeamChannelPickerSugestionHeaderText: " \"Suggested Team Channels\"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double quote escaping, possibly caused by a VS code extension? Applies to other languages as well

@joelfmrodrigues joelfmrodrigues merged commit f13d6a3 into pnp:dev May 3, 2021
@estruyf estruyf mentioned this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants