-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few more tests with a little better desrciption #906
Conversation
@mgwojciech many thanks for this! |
@joelfmrodrigues - fixed. |
@@ -29,14 +29,13 @@ interface IPreviewImageCollection { | |||
|
|||
export class ListItemAttachments extends React.Component<IListItemAttachmentsProps, IListItemAttachmentsState> { | |||
private _spservice: SPservice; | |||
private previewImages: IPreviewImageCollection; | |||
private previewImages: IPreviewImageCollection = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgwojciech looks like all the changes on this file were already previously merged. Could it be from an earlier PR and you forgot to sync your branch since then?
Not an issue as I have checked the code, but something to keep in mind for future PRs to make reviews a little easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I thought I pulled everything before pr, I'll pay more attention to this next time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem at all, was only some files and was simple to compare.
@mgwojciech just reviewed everything, many thanks! I really need to get more experience in testing 😅 |
@mgwojciech sorry, ignore my previous comment, I found a simple way to do this 🤦♂️ |
Added unit tests for FileBrowser component. I added comments to walk the developer through my thought process and explain why certain things are implemented this way. Hope You'll find that sample useful.
If there is any component You would like me to do next, let me know.
Have a great one!