-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-application-breadcrumb to SPFx v1.20.0 #1419
base: main
Are you sure you want to change the base?
Conversation
add back the samples file
Thank you for opening a PR to our samples repo and helping us upgrade our project 👍 |
remove windows build file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tom-daly Awesome work so far 👏👏👏
I really like the changes and the refactor done along the way. You Rock 🤩
Unfortunately I noticed a small left over we need to sort out before we merge 👍. Please do give it a double check 🙏
@@ -2,7 +2,7 @@ declare interface ISiteBreadcrumbStrings { | |||
Title: string; | |||
} | |||
|
|||
declare module 'siteBreadcrumbStrings' { | |||
declare module 'SiteBreadcrumbApplicationCustomizerStrings' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's in this Pull Request?