Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix - Escape single quote in folder name + add support for special chars in folder names #305

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

gautamdsheth
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [x]
New sample? [ ]
Related issues? NA

What's in this Pull Request?

This PR fixes an issue with retrieving folder names containing single quotes as well as special chars like # and %.

This PR also add support to create folder names with special chars like # and % as we are using the new APIs like getFolderByServerRelativePath and addUsingPath

@AJIXuMuK
Copy link
Collaborator

Thanks @gautamdsheth for that change!

@AJIXuMuK AJIXuMuK merged commit 0d80753 into pnp:dev Oct 11, 2020
@AJIXuMuK AJIXuMuK added this to the 2.1.0 milestone Oct 11, 2020
@estruyf estruyf mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants