Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some files #176

Merged
merged 35 commits into from
Nov 19, 2019
Merged

Refactor some files #176

merged 35 commits into from
Nov 19, 2019

Conversation

ken-matsui
Copy link
Member

No description provided.

@ken-matsui ken-matsui changed the title Fix cygwin ctest Refactor some files Nov 16, 2019
@ken-matsui ken-matsui marked this pull request as ready for review November 16, 2019 17:28
@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #176 into develop will increase coverage by 0.24%.
The diff coverage is 83.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
+ Coverage    66.32%   66.56%   +0.24%     
===========================================
  Files           97       98       +1     
  Lines         5422     5501      +79     
===========================================
+ Hits          3596     3662      +66     
- Misses        1826     1839      +13
Impacted Files Coverage Δ
tests/semver/interval.cpp 89.47% <ø> (ø) ⬆️
include/poac/core/resolver/resolve.hpp 0% <ø> (ø) ⬆️
tests/project.cpp 77.77% <ø> (ø) ⬆️
tests/config.cpp 97.26% <ø> (ø) ⬆️
tests/sat.cpp 95.45% <ø> (ø) ⬆️
tests/semver/version.cpp 95.45% <ø> (ø) ⬆️
include/poac/core/builder/builder.hpp 0% <0%> (ø) ⬆️
include/poac/util/semver/exception.hpp 0% <0%> (ø)
include/poac/core/except.hpp 40.5% <0%> (-1.06%) ⬇️
include/poac/util/semver/interval.hpp 53.76% <0%> (-0.59%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ec8d5...d5048a1. Read the comment docs.

@ken-matsui ken-matsui merged commit 3a2bcf3 into develop Nov 19, 2019
@ken-matsui ken-matsui deleted the fix/cygwin-ctest branch November 19, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant