Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow '-jn' style option #943

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

yaito3014
Copy link
Contributor

allowing option like poac build -j8

should we consider poac build -rj8 as poac build --release --jobs 8?

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, does Cargo accept the same style?

@yaito3014
Copy link
Contributor Author

clap accepts no-space variant, so does cargo.

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. It'd be great if you could implement this for other flags, preferably elegantly.

@ken-matsui ken-matsui merged commit b5a1763 into poac-dev:main Jul 19, 2024
15 checks passed
@ken-matsui
Copy link
Member

Also, feel free to implement the -rj8 style if Cargo supports this likewise.

@yaito3014 yaito3014 deleted the no-space-jobs branch July 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants