Add event parsing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of this have to be sort of weaved in with the function parsing since events and functions are all present in the ABI and it wouldn't make sense to require them to parse it twice for each. Additionally, my usage of this shows that its a bit difficult to support providing parameter information in the form of multiple attributes that contain lists with positional data. For instance:
types: [:bool, :string], input_names: ["foo", "bar"]but thats what I ended up going with when adding things so as to avoid unnecessary code changes. If more information is needed out of the function selectors, it might be a good idea to consider structuring the%FunctionSelector{}struct to more closely match the ABI itself.The return value from decoding is a little esoteric, but all of that info is required to get anything informative out of the values given from decoding an event, since they are structured as topics + data and you have to know if they were indexed or not.