Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functions to have mutliple output types #8

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

alexgaribay
Copy link
Contributor

This PR adds support for a function to return multiple types of data. Before, only 1 type was expected for a return. Also, the results of a function are always returned as a list. If a function has no outputs, its value is simply [].

@ayrat555 ayrat555 merged commit ad1c986 into poanetwork:master Aug 16, 2018
@lucasnar
Copy link
Contributor

I remember we had a discussion about this, @amandasposito. Not sure if we opened an issue somewhere, but now it's fixed anyway. Great PR, @alexgaribay! 👍

@lucasnar
Copy link
Contributor

lucasnar commented Aug 16, 2018

Yep, we did open an issue on BlockScout: blockscout/blockscout#337. It should probably be fine to close it now. Or do we still have some work to do on the BlockScout side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants