Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade yup peer dependency to allow v1 #16

Closed
h-yon opened this issue Mar 14, 2023 · 2 comments
Closed

Upgrade yup peer dependency to allow v1 #16

h-yon opened this issue Mar 14, 2023 · 2 comments

Comments

@h-yon
Copy link

h-yon commented Mar 14, 2023

I am seeing warning from yarn like following.

➤ YN0060: │ my_app provides yup (<hash>) with version 1.0.2, which doesn't satisfy what yup-locale-ja requests

versions:

  • yup 1.0.2
  • yup-locale-ja 0.1.3
@pocka pocka mentioned this issue Mar 14, 2023
Closed
10 tasks
@pocka
Copy link
Owner

pocka commented Mar 14, 2023

This package currently supports [email protected] only. Changes are required in order to work with [email protected]. See #17.

pocka added a commit that referenced this issue Mar 24, 2023
@pocka
chore(deps): Support for yup v1
c7ad6aa 
<#16>

Upgraded yup to v1. Thanks to its optional locale structure, I could
keep support for v0.x.

I removed translation for `number.notEqual` due to it already being
removed at v0.24. It's listed in neither CHANGELOG nor migration
guide, and no type definition for that so keeping that leads to
type errors. I believe it's not a breaking change.

See <jquense/yup#705> for more details on
removal of `number.notEqual`.
@pocka
Copy link
Owner

pocka commented Mar 25, 2023

Support for [email protected] was added in v1.0.0

@pocka pocka closed this as completed Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pocka @h-yon