Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception (VS): static assert to make sure that _HAS_EXCEPTIONS is set #4725

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Exception (VS): static assert to make sure that _HAS_EXCEPTIONS is set #4725

merged 1 commit into from
Oct 4, 2024

Conversation

matejk
Copy link
Contributor

@matejk matejk commented Oct 4, 2024

Resolves #4668.

@matejk matejk added this to the Release 1.14.0 milestone Oct 4, 2024
obiltschnig
obiltschnig reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@obiltschnig obiltschnig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't _HAS_EXCEPTIONS MSVC specific?

obiltschnig
obiltschnig requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@obiltschnig obiltschnig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm pretty sure the <typeinfo> header is needed on some platforms.

@matejk matejk force-pushed the 4668_verify_has_exceptions branch 2 times, most recently from 8c5055c to 5a0b865 Compare October 4, 2024 08:51
@matejk
Copy link
Contributor Author

matejk commented Oct 4, 2024

Isn't _HAS_EXCEPTIONS MSVC specific?

I realised that quick and corrected it :)

@matejk
Copy link
Contributor Author

matejk commented Oct 4, 2024

Also, I'm pretty sure the <typeinfo> header is needed on some platforms.

Also corrected.

@matejk matejk changed the title Exception: static assert to make sure that _HAS_EXCEPTIONS is set Exception (VS): static assert to make sure that _HAS_EXCEPTIONS is set Oct 4, 2024
@matejk matejk merged commit 3c01eec into main Oct 4, 2024
43 checks passed
@matejk matejk deleted the 4668_verify_has_exceptions branch October 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obiltschnig obiltschnig Awaiting requested review from obiltschnig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.14.0
Development

Successfully merging this pull request may close these issues.

Cross-module exception issue with pre-compiler define _HAS_EXCEPTIONS=0 used in an application
2 participants
@matejk @obiltschnig