-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parsing of the Amount from the Transaction ID #537
Implement parsing of the Amount from the Transaction ID #537
Conversation
✅ Tests will run for this PR. Once they succeed it can be merged. |
296a5d2
to
7dde257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job with the tests and the corner cases!!!
Please see my two comments regarding !=BGN and additional safety with marking the transaction as unrecognized if parsing didn't work.
Assuming that the position of the amount is the exact same on every transactionId, and the amount is always represented as a decimal number, can't we just use |
…es different than BGN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and special thanks again for the extra safety!
debtorAccount: { | ||
iban: 'BG21UNCR111111111111', | ||
}, | ||
debtorName: 'Name not relevant for the example', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Great example for setting the high bar of how test data should look like!
@sashko9807 Sorry, I just saw your comment. Here are my thoughts:
|
Closes #1462 (from the frontend repo)