add create campaign agreements validation #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if any of the 3 agreements for creating campaign are not checked -> throw a HttpException with status 405
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
requested changes
Jun 25, 2024
| !createCampaignApplicationDto.transparencyTermsAccepted || | ||
| !createCampaignApplicationDto.personalInformationProcessingAccepted | ||
| ) { | ||
| throw new HttpException('All agreements must be checked', HttpStatus.METHOD_NOT_ALLOWED) |
There was a problem hiding this comment.
Method not allowed (405) is not the appropriate http response to respond with in such scenarios.
We've established some practice to respond with Bad Request (400) for invalid DTO content, but I suppose you could also respond with Unprocessable Content (422). Either of them are semantically fine.
http error code is now 400 in validation for all 3 agreements in create method
changed the error from HttpException to BadRequestException for the agreements validation in create method in campaign-application.service.ts
sashko9807
approved these changes
Jun 25, 2024
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-api
that referenced
this pull request
Jun 30, 2024
* add create campaign agreements validation if any of the 3 agreements for creating campaign are not checked -> throw a HttpException with status 405 * fix http error status code in campaign-application.service http error code is now 400 in validation for all 3 agreements in create method * fix throw new BadRequestException changed the error from HttpException to BadRequestException for the agreements validation in create method in campaign-application.service.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if any of the 3 agreements for creating campaign are not checked -> throw a HttpException with status 405
add validation if the 3 agreements are checked(true)
add test
update create-campaign-application.dto(acceptTermsAndConditions, transparencyTermsAccepted,personalInformationProcessingAccepted are boolean)
Motivation and context
Testing
Steps to test
New endpoints
Environment
New environment variables:
NEW_ENV_VAR: env var detailsNew or updated dependencies:
dependency/namev1.0.0v2.0.0