ViewCampaignPage: Show page not found on wrong slug #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashko9807
changed the title
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
ani-kalpachka
approved these changes
Aug 2, 2023
igoychev
approved these changes
Aug 2, 2023
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the url of the campaign, is invalid due to some typos being made. And since no data is coming from the server, the only thing the user sees, is a spinner going on forever.
Fix this by rendering NotFoundPage, if the server has returned an error
Closes N/A
Motivation and context
Improves UX