Spike: Generate whole feed using an XML Generator #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds podcast namespace - adds filter to modify rss items - adds atom:contributor and podcast:person to item
This breaks Shows overrides, but I will do these all at once at the end.
- language - fyyd:verify - podcast:funding - podcast:license - itunes:owner - itunes:image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the beginning of the plugin, we generated RSS the same way WordPress does: with templates. Gradually, we started to generate element by element using XML generator functions, but the main feed remained a template.
This Spike explores generating the whole RSS Feed using an XML generator, guaranteeing valid XML.