Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to handle update of extensions only for specific range of Podman Desktop #7867

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jul 1, 2024

What does this PR do?

for now, when there is a new version of an extension it is automatically updating the version
here we're bringing another level of control where we can flag extensions requiring a given minimal version of Podman Desktop to do the update. (updating metadata of the catalog)

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #7663

How to test this PR?

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner July 1, 2024 07:53
@benoitf benoitf requested review from jeffmaury and axel7083 and removed request for a team July 1, 2024 07:53
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems this PR only deals with automatic updates. Is manual update handled in a separate issue/PR

@benoitf
Copy link
Collaborator Author

benoitf commented Jul 2, 2024

@jeffmaury there is no manual update supported right now so yes it would come separately

@benoitf benoitf merged commit 8fefc91 into podman-desktop:main Jul 2, 2024
11 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.12.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman Desktop should check if the version is compliant before trying to update
4 participants