Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change s2_cell_id to uint64 in ClientWeather.proto #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codename-art
Copy link

s2_cell_id should be uint64 to avoid overflowing like in POGOProtos/Map/MapCell.proto

s2_cell_id should be uint64 to avoid overflowing like in POGOProtos/Map/MapCell.proto
@niicojs
Copy link

niicojs commented Dec 22, 2017

In the app, it seems to be a "long" (as in 'signed').
It's indeed a "ulong" in MapCell.

I see your point, but I guess we should stick to what the app is doing.

@codename-art
Copy link
Author

codename-art commented Dec 22, 2017

There is no errors while scanning in Russia, for example correct values,
image

But in some regions s2_cell_id value is too high, for example in Canada:
image

Nevertheless s2sphere library finds cell with same center coordinates, but with level 30 instead of 10 for negative s2_cell_id. Using this cell it is possible to find correct s2cell in this way:

cell_id = s2sphere.CellId(raw_id)
return s2sphere.Cell.from_face_pos_level(cell_id.face(), cell_id.pos(), 10)

@Furtif
Copy link

Furtif commented Dec 22, 2017

I come here to see if this is good, I have in my repo, I wanted to thank for the participation Furtif/POGOProtos#4

@niicojs niicojs added the bug label Dec 23, 2017
@niicojs
Copy link

niicojs commented Dec 24, 2017

Did you test fixed64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants