Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of deprecation warnings. #181

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix a bunch of deprecation warnings. #181

merged 2 commits into from
Jun 20, 2023

Conversation

mbrandonw
Copy link
Member

No description provided.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a nav branch going too that we should revisit soon.

Comment on lines +149 to 150
.scope(state: \.cubes[index], action: { $0 })
.actionless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency should we use absurd here too, or should we use .actionless above?

@mbrandonw mbrandonw merged commit 5ef99f5 into main Jun 20, 2023
4 checks passed
@mbrandonw mbrandonw deleted the modernize-some-things branch June 20, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants