Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove firstLaunchOnboarding #198

Conversation

imjn
Copy link
Contributor

@imjn imjn commented Jan 17, 2024

Hi 👋🏽
I couldn't find anywhere using the computed property firstLaunchOnboarding of RootReducer.State.

So I'm removing it in case it is unnecessary.

@imjn imjn marked this pull request as ready for review January 17, 2024 14:09
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 595afc1 into pointfreeco:main Jan 25, 2024
1 of 2 checks passed
@imjn imjn deleted the remove-unused-property-firstLaunchOnboarding branch January 25, 2024 21:58
mbrandonw pushed a commit that referenced this pull request Apr 7, 2024
stephencelis added a commit that referenced this pull request Apr 9, 2024
* Bump

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Remove firstLaunchOnboarding (#198)

Co-authored-by: Stephen Celis <[email protected]>

* use enum reducers

* fix some warnings

* udpate last destination reducer

* ignore some errors

* wip

* wip

* wip

* wip

---------

Co-authored-by: Imajin Kawabe <[email protected]>
Co-authored-by: Brandon Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants