Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to make V0 LocalNet work on WSL2 #1

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

msmania
Copy link
Contributor

@msmania msmania commented Apr 4, 2023

  • Remove go.mod.local and use the latest go.mod in the pocket-core branch
  • Update the tendermint path in go.mod before go build
    • docker/pokt-net/dev-tm/Dockerfile for scaffold
    • docker/pokt-net/dev-tm/prepare-tendermint.sh for playground nodes
  • Clean up pocket-core/vendor before creating a container
  • Simplify data directory creation in stacks/pokt-net/scaffold/up.sh because paths=($(echo $nodes | tr " " "\n")) causes a syntax error somehow
  • Update some critical parameters in genesis.json with the same values as mainnet

bin/pokt-net/utils.sh Outdated Show resolved Hide resolved
docker/pokt-net/dev-tm/Dockerfile Show resolved Hide resolved
docker/pokt-net/dev-tm/Dockerfile Show resolved Hide resolved
docker/pokt-net/dev-tm/prepare-tendermint.sh Outdated Show resolved Hide resolved
stacks/pokt-net/scaffold/cleanup.sh Show resolved Hide resolved
stacks/pokt-net/scaffold/up.sh Outdated Show resolved Hide resolved
- Remove go.mod.local and go.mod.tendermint and use the latest go.mod
  in the actual branches
- Update the tendermint path in go.mod before `go build`
  - docker/pokt-net/dev-tm/Dockerfile for scaffold
  - docker/pokt-net/dev-tm/prepare-tendermint.sh for playground nodes
- Clean up the vendor directories before creating a container
- No need to create data subdirectory before starting pocket
- Update some critical parameters in genesis.json with the same values as mainnet
@msmania msmania requested a review from Olshansk April 5, 2023 02:13
@Olshansk Olshansk added documentation Improvements or additions to documentation enhancement New feature or request bug Something isn't working labels Apr 5, 2023
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but otherwise LGTM! Feel free to squash and merge

docker/pokt-net/dev-tm/Dockerfile Show resolved Hide resolved
stacks/pokt-net/scaffold/up.sh Outdated Show resolved Hide resolved
@msmania msmania merged commit 324b3ac into main Apr 5, 2023
@msmania msmania deleted the toshi/dev branch April 5, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants