Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Integrations): P2P-Persistence integration #15
docs(Integrations): P2P-Persistence integration #15
Changes from 5 commits
67c9abd
33b37de
48f3ea4
a60e941
fee493a
57987ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add details that point #1 is "synchronous communication" and point #2 is "asynchronous communication".
We could even copy-pasta the mermaid diagram from the implementation repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your points but perhaps this document should be less "loaded" with technicalities and try to explain things in simpler terms, good enough to have an idea of how it works at a high level
Regarding the diagram, if we copy-pasta it, we would have to keep track of it and keep them aligned.
I am sure that whoever reads this and is interested in how it works under the hood, they already pulled the main repo, probably as a first step actually.
Lemme know where your mind is at. Maybe we could ask Jess' point of view on this. I guess her input would be valuable. (not tagging her on purpose in the meantime).
My 2c. Let's keep it simple, actually, I was thinking that it might sound even too technical already perhaps 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. This whole thing spec needs a revamp and I personally think pokt-network/pocket#438 does a better job at introducing the P2P module.
There will be more changes as we also have decided to adopt LibP2P.
After we launch V1 (and have real data), we can write a single whitepaper capturing everything and publish on arxiv :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Should we backticket
P2P
andPersistence
?