Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHDEBT] Tackle TODOs in shared/modules #232

Closed
5 tasks
andrewnguyen22 opened this issue Sep 18, 2022 · 0 comments · Fixed by #260
Closed
5 tasks

[TECHDEBT] Tackle TODOs in shared/modules #232

andrewnguyen22 opened this issue Sep 18, 2022 · 0 comments · Fixed by #260
Assignees
@andrewnguyen22
Labels
code health Nice to have code improvement core Core infrastructure - protocol related
Milestone
M*: Pocket QoL (Q...

Comments

@andrewnguyen22
Copy link
Contributor

Objective

  • Tackle / recategorize all non-blocked TODOs in shared/modules

Origin Document

Techdebt week emphasizes code health. Particularly, removing all placeholder and hacky code.

The past few months, shared/modules have built up quite a few TODOs.

The PR should remove all non-blocked TODOs

Goals

  • Reduce cognitive load
  • Increase code health

Deliverable

  • Code complete implementation
  • Updated changelog.md

General issue deliverables

  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

Creator: @andrewnguyen22
@andrewnguyen22 andrewnguyen22 added the code health Nice to have code improvement label Sep 18, 2022
@andrewnguyen22 andrewnguyen22 self-assigned this Sep 18, 2022
@Olshansk Olshansk added the core Core infrastructure - protocol related label Sep 19, 2022
andrewnguyen22 pushed a commit that referenced this issue Sep 30, 2022
issue-#232
e76880f
@andrewnguyen22 andrewnguyen22 mentioned this issue Sep 30, 2022
Merged
15 tasks
andrewnguyen22 pushed a commit that referenced this issue Oct 10, 2022
Merge branch 'main' into issue-#232
dcf9575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewnguyen22 andrewnguyen22

Labels
code health Nice to have code improvement core Core infrastructure - protocol related
Projects
V1 Dashboard
Status: Done
Milestone
M*: Pocket QoL (Quality of Life)
Development

Successfully merging a pull request may close this issue.

[TECHDEBT] Tackle TODOs in shared/modules Issue #232 pokt-network/pocket
2 participants
@Olshansk @andrewnguyen22