[TECHDEBT] [P2P] Raintree test suite improvements: Double check expected calls counting

[deblasis]

Objective

Tend for this TODO left in the code:

./p2p/module_raintree_test.go:// INVESTIGATE(olshansky): Double check that how the expected calls are counted is accurate per the

Origin Document

Looking at the configuration for a single RainTree test:

Along with the visuals and the configs for a single test:

It is not clear what these are supposed to mean in the context of gossip.

Goals

• Make the RainTree testing framework counters more intuitive in terms of reads/writes from/to the network
• Add some clarifying documentation to the RainTree testing framework/modules

Deliverable

A PR that includes the following

• Changes to how the RainTree testing framework counters are managed and validated
• Supporting documentation on what the counters mean and why

Non-goals / Non-deliverables

• Modify Raintree implementation
• Code cleanup
• Code refactoring
• Add the tooling/utilities to gain visibility into RainTree
• Add the tooling/utilities to generate RainTree unit tests

General issue deliverables

• Update the appropriate CHANGELOG
• Update any relevant READMEs (local and/or global)
• Update any relevant global documentation & references
• If applicable, update the source code tree explanation
• If applicable, add or update a state, sequence or flowchart diagram using mermaid

Testing Methodology

• Task specific tests: make test_p2p
• All tests: make test_all
• LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

---

Creator: @deblasis
Co-Owners: @Olshansk

[Olshansk]

This is being tackled in #179.