Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] Handle Errors During Transaction Processing #346

Closed
8 tasks
Olshansk opened this issue Nov 12, 2022 · 0 comments
Closed
8 tasks

[Utility] Handle Errors During Transaction Processing #346

Olshansk opened this issue Nov 12, 2022 · 0 comments
Labels
bug Something isn't working - expected behaviour is incorrect core Core infrastructure - protocol related utility Utility specific changes

Comments

@Olshansk
Copy link
Member

Objective

Make sure that transaction processing errors are handled correctly when an issue is seen during the ApplyBlock process in utility/block.go.

Origin Document

This task was meant to be tackled in #315, but while reviewing #285, the team realized it was left out:

Screen Shot 2022-11-11 at 8 21 05 PM

An error during transaction processing could happen due to a multitude of reasons:

  • Invalid Transaction
  • Internal Error
  • Nil Transactions
  • Etc...

Goals

  • Identify the different situations in which transaction processing could result in an error
  • Design & implement Handle the different situations identified above

Deliverable

  • A PR that implements this error management
  • Unit tests handling the various situations that could cause transaction processing errors
  • Updated documentation on different reasons transaction processing could error

Non-goals / Non-deliverables

  • Updates to interfaces exposed by the modules
  • New business logic related to Pocket utility

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

Testing Methodology

  • New tests: <UPDATE_ME>
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @Olshansk
Co-Owners: @andrewnguyen22

@Olshansk Olshansk added core Core infrastructure - protocol related utility Utility specific changes labels Nov 12, 2022
@Olshansk Olshansk added the bug Something isn't working - expected behaviour is incorrect label Nov 12, 2022
Olshansk added a commit that referenced this issue Nov 15, 2022
@Olshansk Olshansk self-assigned this Dec 15, 2022
@Olshansk Olshansk removed their assignment Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working - expected behaviour is incorrect core Core infrastructure - protocol related utility Utility specific changes
Projects
Status: Done
Development

No branches or pull requests

1 participant